bernardodemarco commented on code in PR #10602:
URL: https://github.com/apache/cloudstack/pull/10602#discussion_r2007417728
##########
ui/src/views/compute/StartVirtualMachine.vue:
##########
@@ -237,7 +237,7 @@ export default {
id: this.resource.id
}
for (const key in values) {
- if (values[key]) {
+ if (values[key] || values[key] === false) {
Review Comment:
Okay. Specifically in this form, in which all fields are select components
(except for the `considerlasthost`), the UI does not allow the values to be
empty.
However, I think that's a great idea to keep the if statement how you
proposed, since that we could, in the future, add more fields to the form that
can accept empty/nullable values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
