phsm commented on code in PR #10594:
URL: https://github.com/apache/cloudstack/pull/10594#discussion_r2010180269


##########
scripts/vm/network/security_group.py:
##########
@@ -607,12 +622,16 @@ def default_network_rules(vm_name, vm_id, vm_ip, vm_ip6, 
vm_mac, vif, brname, se
         if vm_ip:
             execute("iptables -A " + vmchain_default + " -m physdev 
--physdev-is-bridged --physdev-in " + vif + " -m set ! --match-set " + 
vmipsetName + " src -j DROP")
             execute("iptables -A " + vmchain_default + " -m physdev 
--physdev-is-bridged --physdev-out " + vif + " -m set ! --match-set " + 
vmipsetName + " dst -j DROP")
-            execute("iptables -A " + vmchain_default + " -m physdev 
--physdev-is-bridged --physdev-in " + vif + " -m set --match-set " + 
vmipsetName + " src -p udp --dport 53  -j RETURN ")

Review Comment:
   Update regarding the missing '-j DROP' rules in the chain FORWARD chain:
   I double checked, those drop rules are present in the chain. Seems I just 
wrongly grep-ed while preparing the listings for the previous post.
   
   Edited the rules listing in the previous to contain these rules.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to