DaanHoogland commented on code in PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#discussion_r2018100689
##########
utils/src/main/java/org/apache/cloudstack/utils/redfish/RedfishClient.java:
##########
@@ -265,12 +265,12 @@ private String getRequestPathForCommand(RedfishCmdType
cmd, String resourceId) {
if (StringUtils.isBlank(resourceId)) {
throw new RedfishException(String.format("Command '%s'
requires a valid resource ID '%s'.", cmd, resourceId));
}
- return String.format("%s%s", SYSTEMS_URL_PATH, resourceId);
Review Comment:
so line 263 could read
```
return SYSTEMS_URL_PATH + "/";
```
o.r use File.SEPARATOR and/or String.format(). I think we should test it to
make sure, but would not be a big issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
