alexandru-bagu commented on code in PR #10641:
URL: https://github.com/apache/cloudstack/pull/10641#discussion_r2019792215
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -788,12 +793,6 @@ protected void runInContext() {
}
}
} else {
- //previously vm has ip and nic table has ip address. After
vm restart or stop/start
Review Comment:
In my opinion, if we cannot know if the VM still has the IP assigned or not
then we should not modify the database. In other words, we should be sure that
the VM's NIC does not have an IP assigned before updating the database.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
