slavkap commented on code in PR #9833:
URL: https://github.com/apache/cloudstack/pull/9833#discussion_r2003165202
##########
plugins/storage/volume/storpool/src/main/java/com/cloud/hypervisor/kvm/storage/StorPoolStorageAdaptor.java:
##########
@@ -149,6 +160,10 @@ public static String getVolumeNameFromPath(final String
volumeUuid, boolean tild
}
public static boolean attachOrDetachVolume(String command, String type,
String volumeUuid) {
+ if (volumeUuid == null) {
Review Comment:
@sureshanaparti, yes, there is an option for boolean/enum, but this method
is used almost everywhere in the StorPool plug-in (agent's part). I don't think
this PR is the place for refactoring
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
