GutoVeronezi commented on code in PR #10645:
URL: https://github.com/apache/cloudstack/pull/10645#discussion_r2032963418
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java:
##########
@@ -206,8 +206,9 @@ public LibvirtVMDef.InterfaceDef plug(NicTO nic, String
guestOsType, String nicA
}
String trafficLabel = nic.getName();
Integer networkRateKBps = 0;
+ Integer bitsPerMbpsToKbps = 125;
if (libvirtVersion > ((10 * 1000 + 10))) {
- networkRateKBps = (nic.getNetworkRateMbps() != null &&
nic.getNetworkRateMbps().intValue() != -1) ?
nic.getNetworkRateMbps().intValue() * 128 : 0;
+ networkRateKBps = (nic.getNetworkRateMbps() != null &&
nic.getNetworkRateMbps().intValue() != -1) ?
nic.getNetworkRateMbps().intValue() * bitsPerMbpsToKbps : 0;
Review Comment:
As this piece of code is repeated several times, we could extract it to a
common method (in VifDriverBase perhaps?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
