shwstppr commented on code in PR #10583:
URL: https://github.com/apache/cloudstack/pull/10583#discussion_r2033072393
##########
test/integration/smoke/test_events_resource.py:
##########
@@ -161,21 +157,12 @@ def test_01_events_resource(self):
virtual_machine.restore(self.apiclient)
time.sleep(self.services["sleep"])
virtual_machine.detach_volume(self.apiclient, volume)
- volume.delete(self.apiclient)
- self.cleanup.remove(volume)
ts = str(time.time())
virtual_machine.update(self.apiclient, displayname=ts)
- virtual_machine.delete(self.apiclient)
- self.cleanup.remove(virtual_machine)
account_network.update(self.apiclient, name=account_network.name + ts)
- account_network.delete(self.apiclient)
- self.cleanup.remove(account_network)
+ virtual_machine.start(self.apiclient)
Review Comment:
@Pearl1594 Your change is correct in itself but I feel now we are verifying
lesser set of actions. I would prefer if we can have only the change that fixes
restore VM.
Like if earlier we were verifying 20 events, now we might only be doing 5
events.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
