JoaoJandre commented on code in PR #10686:
URL: https://github.com/apache/cloudstack/pull/10686#discussion_r2037312096
##########
api/src/test/java/org/apache/cloudstack/api/command/user/vpc/CreateVPCCmdTest.java:
##########
@@ -39,17 +38,21 @@
import org.springframework.test.util.ReflectionTestUtils;
@RunWith(MockitoJUnitRunner.class)
-public class CreateVPCCmdTest extends TestCase {
+public class CreateVPCCmdTest {
@Mock
public VpcService _vpcService;
@Mock
public EntityManager _entityMgr;
@Mock
public AccountService _accountService;
- private ResponseGenerator responseGenerator;
+ @Mock
+ private ResponseGenerator _responseGenerator;
Review Comment:
```suggestion
private ResponseGenerator responseGenerator;
```
##########
api/src/test/java/org/apache/cloudstack/api/command/user/network/UpdateNetworkCmdTest.java:
##########
@@ -41,7 +41,10 @@ public class UpdateNetworkCmdTest {
NetworkService networkService;
@Mock
public EntityManager _entityMgr;
- private ResponseGenerator responseGenerator;
+ @Mock
+ private ResponseGenerator _responseGenerator;
Review Comment:
```suggestion
private ResponseGenerator responseGenerator;
```
##########
server/src/test/java/com/cloud/network/NetworkServiceImplTest.java:
##########
@@ -141,11 +146,11 @@ public class NetworkServiceImplTest {
@Mock
VpcManager vpcMgr;
@Mock
- NetworkOrchestrationService networkManager;
+ NetworkOrchestrationService _networkMgr;
@Mock
AlertManager alertManager;
@Mock
- DataCenterDao dcDao;
+ DataCenterDao _dcDao;
Review Comment:
Are these name changes required? They go against the Java naming conventions
##########
server/src/test/java/com/cloud/network/NetworkServiceImplTest.java:
##########
@@ -118,6 +118,11 @@
@RunWith(MockitoJUnitRunner.class)
public class NetworkServiceImplTest {
+ @Mock
+ Object job;
+ @Mock
+ Object _responseObject;
Review Comment:
```suggestion
Object responseObject;
```
##########
api/src/test/java/org/apache/cloudstack/api/command/admin/vm/MigrateVirtualMachineWithVolumeCmdTest.java:
##########
@@ -68,6 +68,12 @@ public class MigrateVirtualMachineWithVolumeCmdTest {
@Mock
Host hostMock;
+ @Mock
+ private Object job;
+
+ @Mock
+ private Object _responseObject;
Review Comment:
```suggestion
private Object responseObject;
```
##########
plugins/hypervisors/vmware/src/test/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImplTest.java:
##########
@@ -69,6 +69,8 @@ public class VmwareManagerImplTest {
private Map<String, String> clusterDetails;
@Mock
private Map<String, String> hostDetails;
+ @Mock
+ private Map<String, Object> _configParams;
Review Comment:
```suggestion
private Map<String, Object> configParams;
```
##########
plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmdTest.java:
##########
@@ -111,6 +111,9 @@ public class SAML2LoginAPIAuthenticatorCmdTest {
@Mock
HttpServletRequest req;
+ @Mock
+ Object _responseObject;
Review Comment:
```suggestion
Object responseObject;
```
##########
plugins/hypervisors/vmware/src/test/java/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java:
##########
@@ -185,6 +183,8 @@ public VmwareHypervisorHost getHyperHost(VmwareContext
context, Command cmd) {
VimPortType vimService;
@Mock
HostCapability hostCapability;
+ @Mock
+ ManagedObjectReference _morHyperHost;
Review Comment:
```suggestion
ManagedObjectReference morHyperHost;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
