DaanHoogland commented on code in PR #10721:
URL: https://github.com/apache/cloudstack/pull/10721#discussion_r2046134471
##########
usage/src/main/java/com/cloud/usage/parser/NetworkOfferingUsageParser.java:
##########
@@ -155,9 +154,8 @@ private static void createUsageRecord(int type, long
runningTime, Date startDate
// Create the usage record
String usageDesc = "Network offering:" + noId + " for Vm : " + vmId +
" usage time";
- long defaultNic = (isDefault) ? 1 : 0;
UsageVO usageRecord =
- new UsageVO(zoneId, account.getId(), account.getDomainId(),
usageDesc, usageDisplay + " Hrs", type, new Double(usage), vmId, null, noId,
null, defaultNic,
+ new UsageVO(zoneId, account.getId(), account.getDomainId(),
usageDesc, usageDisplay + " Hrs", type, new Double(usage), vmId, null, noId,
null, noId,
Review Comment:
@winterhazel the usage_id is meant to be the id of the resource being used,
isn’t it? Why would this be different for usage_type 13 than it is for other
usage_types?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
