weizhouapache commented on code in PR #10735:
URL: https://github.com/apache/cloudstack/pull/10735#discussion_r2046865658
##########
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java:
##########
@@ -2738,7 +2739,7 @@ public boolean configure(String name, Map<String, Object>
params) throws Configu
_inSystemVM = true;
}
- _storageIp = (String)params.get("storageip");
+ _storageIp = (String)ObjectUtils.firstNonNull(params.get("storageip"),
_eth1ip);
Review Comment:
the logic looks good to me
may use MapUtils
```
MapUtils.getString(params, "storageip", _eth1ip);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
