weizhouapache commented on code in PR #10746:
URL: https://github.com/apache/cloudstack/pull/10746#discussion_r2053418031
##########
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##########
@@ -1644,8 +1644,8 @@ public Network createGuestNetwork(CreateNetworkCmd cmd)
throws InsufficientCapac
if (ipv4 && Objects.isNull(startIP)) {
throw new CloudRuntimeException("IPv4 address range needs to
be provided");
}
- if (ipv6 && Objects.isNull(startIPv6)) {
- throw new CloudRuntimeException("IPv6 address range needs to
be provided");
+ if (ipv6) {
+ logger.info(String.format("ip range for network '%s' is
specified as %s - %s", name, startIPv6, endIPv6));
Review Comment:
```suggestion
logger.info(String.format("ip range for network '%s' is
specified as %s - %s", name, startIPv6, endIPv6));
```
##########
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##########
@@ -1644,8 +1644,8 @@ public Network createGuestNetwork(CreateNetworkCmd cmd)
throws InsufficientCapac
if (ipv4 && Objects.isNull(startIP)) {
throw new CloudRuntimeException("IPv4 address range needs to
be provided");
}
- if (ipv6 && Objects.isNull(startIPv6)) {
- throw new CloudRuntimeException("IPv6 address range needs to
be provided");
+ if (ipv6) {
+ logger.info(String.format("ip range for network '%s' is
specified as %s - %s", name, startIPv6, endIPv6));
Review Comment:
```suggestion
s_logger.info(String.format("ip range for network '%s' is
specified as %s - %s", name, startIPv6, endIPv6));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
