DaanHoogland commented on code in PR #10533:
URL: https://github.com/apache/cloudstack/pull/10533#discussion_r2059890086
##########
ui/src/store/modules/user.js:
##########
@@ -556,6 +555,9 @@ const user = {
commit('SET_DOMAIN_STORE', domainStore)
},
SetCsLatestVersion ({ commit }, rolename) {
+ if (!vueProps.$config.notifyLatestCSVersion) {
+ return
+ }
Review Comment:
@rohityadavcloud , I am not sure this would be easily cleanly implemented.
https://api.github.com/repos/apache/cloudstack/releases give a cleanish yaml
with results.
In contrast https://dlcdn.apache.org/cloudstack/releases/ gives a directory
listing.
https://download.cloudstack.org/ also gives a directory listing which is
really messy.
I would prefer to continue as is but make the retrieval of new version
optional, advising operators to set it on test environments and to disable it
in production.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
