DaanHoogland commented on code in PR #10848:
URL: https://github.com/apache/cloudstack/pull/10848#discussion_r2084290771


##########
usage/src/main/java/com/cloud/usage/UsageManagerImpl.java:
##########
@@ -331,7 +331,9 @@ public boolean start() {
             _sanity = _sanityExecutor.scheduleAtFixedRate(new SanityCheck(), 
1, _sanityCheckInterval, TimeUnit.DAYS);
         }
 
+        _usageJobDao.removeLastOpenJobsOwned(_hostname, 0);

Review Comment:
   @sureshanaparti , I think this should be done before the scheduling to 
prevent a race condition. It is unlikely but not impossible that we delete a 
job here that we just scheduled.
   Do you agree?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to