Copilot commented on code in PR #10850:
URL: https://github.com/apache/cloudstack/pull/10850#discussion_r2084685700
##########
plugins/storage/volume/linstor/src/main/java/org/apache/cloudstack/storage/datastore/driver/LinstorPrimaryDataStoreDriverImpl.java:
##########
@@ -1504,22 +1507,77 @@ public void takeSnapshot(SnapshotInfo snapshotInfo,
AsyncCompletionCallback<Crea
@Override
public boolean canProvideStorageStats() {
- return false;
+ return true;
}
@Override
public Pair<Long, Long> getStorageStats(StoragePool storagePool) {
- return null;
+ s_logger.debug(String.format("Requesting storage stats: %s",
storagePool));
+ return LinstorUtil.getStorageStats(storagePool.getHostAddress(),
getRscGrp(storagePool));
}
@Override
public boolean canProvideVolumeStats() {
- return false;
+ return LinstorConfigurationManager.VolumeStatsCacheTime.value() > 0;
+ }
+
+ /**
+ * Updates the cache map containing current allocated size data.
+ * @param api Linstor Developers api object
+ */
+ private void fillVolumeStatsCache(DevelopersApi api) {
+ try {
+ s_logger.trace("Start volume stats cache update");
+ List<ResourceWithVolumes> resources = api.viewResources(
+ Collections.emptyList(),
+ Collections.emptyList(),
+ Collections.emptyList(),
+ null,
+ null,
+ null);
+
+ List<ResourceDefinition> rscDfns = api.resourceDefinitionList(
+ Collections.emptyList(), true, null, null, null);
+
+ HashMap<String, Long> resSizeMap = new HashMap<>();
+ for (ResourceDefinition rscDfn : rscDfns) {
+ if (CollectionUtils.isNotEmpty(rscDfn.getVolumeDefinitions()))
{
+ resSizeMap.put(rscDfn.getName(),
rscDfn.getVolumeDefinitions().get(0).getSizeKib() * 1024);
+ }
+ }
+
+ HashMap<String, Long> allocSizeMap = new HashMap<>();
+ for (ResourceWithVolumes rsc : resources) {
+ if (!LinstorUtil.isRscDiskless(rsc) &&
!rsc.getVolumes().isEmpty()) {
+ long allocatedBytes =
allocSizeMap.getOrDefault(rsc.getName(), 0L);
+ allocSizeMap.put(rsc.getName(), Math.max(allocatedBytes,
rsc.getVolumes().get(0).getAllocatedSizeKib() * 1024));
Review Comment:
[nitpick] Consider whether taking the maximum allocated size from the first
volume is the intended design. If multiple volumes per resource are possible
and the total allocated size is desired, then summing the allocated sizes might
be more appropriate.
```suggestion
long totalAllocatedBytes = rsc.getVolumes().stream()
.mapToLong(volume -> volume.getAllocatedSizeKib() *
1024)
.sum();
allocSizeMap.put(rsc.getName(), totalAllocatedBytes);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
