Pearl1594 commented on code in PR #10912:
URL: https://github.com/apache/cloudstack/pull/10912#discussion_r2104429177
##########
plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixStartCommandWrapper.java:
##########
@@ -241,7 +242,7 @@ private void prepareDisks(VirtualMachineTO vmSpec,
CitrixResourceBase citrixReso
List<DiskTO> disks = new ArrayList<DiskTO>(vmSpec.getDisks().length);
int index = 0;
for (final DiskTO disk : vmSpec.getDisks()) {
- if (Volume.Type.ISO.equals(disk.getType())) {
+ if (Volume.Type.ISO.equals(disk.getType()) &&
Objects.nonNull(disk.getPath())) {
Review Comment:
If we attach an iso to a VM that has a configdrive - it replaces the
configdrive iso. However, Im not sure of the historic behavior for this,
because, it seems like configdrive has been broken on XenServer for quite a few
releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
