vits-hugs commented on code in PR #10898: URL: https://github.com/apache/cloudstack/pull/10898#discussion_r2105216543
########## engine/schema/templateConfig.sh: ########## @@ -79,7 +79,7 @@ templates=( "kvm:https://download.cloudstack.org/systemvm/${CS_VERSION}/systemvm PARENTPATH="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )/dist/systemvm-templates/" mkdir -p $PARENTPATH -METADATAFILE=${PARENTPATH}"metadata.ini" -echo > $METADATAFILE +METADATAFILE="${PARENTPATH}metadata.ini" +echo > "$METADATAFILE" SOURCEFILE=${PARENTPATH}'md5sum.txt' Review Comment: So, when i tested, i got the result below, which is the expected behaviour, i don't know how you got the "/usr/bin/..." path, since the command "pwd -P" should return your current working directory. ``` vitor@vitor-Inspiron-5480:/tmp$ mkdir "aa bb" vitor@vitor-Inspiron-5480:/tmp$ cd aa\ bb/ vitor@vitor-Inspiron-5480:/tmp/aa bb$ PARENTPATH="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )/dist/systemvm-templates/" vitor@vitor-Inspiron-5480:/tmp/aa bb$ echo $PARENTPATH /tmp/aa bb/dist/systemvm-templates/ vitor@vitor-Inspiron-5480:/tmp/aa bb$ METADATAFILE=${PARENTPATH}"metadata.ini" vitor@vitor-Inspiron-5480:/tmp/aa bb$ echo > "$METADATAFILE" bash: /tmp/aa bb/dist/systemvm-templates/metadata.ini: No such file or directory vitor@vitor-Inspiron-5480:/tmp/aa bb$ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
