DaanHoogland commented on code in PR #10916:
URL: https://github.com/apache/cloudstack/pull/10916#discussion_r2106793174


##########
server/src/main/java/com/cloud/api/query/QueryManagerImpl.java:
##########
@@ -3485,7 +3485,9 @@ private Ternary<List<Long>, Integer, String[]> 
searchForDiskOfferingsIdsAndCount
 
                 SearchCriteria<DiskOfferingVO> sc = 
diskOfferingSearch.create();
                 sc.setParameters("computeOnly", false);
-                sc.setParameters("activeState", DiskOffering.State.Active);
+                if (state != null) {
+                    sc.setParameters("state", state);
+                }

Review Comment:
   it is a API output that is being removed. This might cause backwards 
incompatibility issues.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to