weizhouapache commented on code in PR #10916: URL: https://github.com/apache/cloudstack/pull/10916#discussion_r2106742712
########## server/src/main/java/com/cloud/api/query/QueryManagerImpl.java: ########## @@ -3483,6 +3483,8 @@ private Ternary<List<Long>, Integer, String[]> searchForDiskOfferingsIdsAndCount diskOfferingSearch.and("displayOffering", diskOfferingSearch.entity().getDisplayOffering(), Op.EQ); } + diskOfferingSearch.and("activeState", diskOfferingSearch.entity().getState(), Op.EQ); Review Comment: L3465 is executed only when `state != null` if state is not passed in the API parameter, it will not be executed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org