DaanHoogland opened a new issue, #11033:
URL: https://github.com/apache/cloudstack/issues/11033

   logic looks good, but the code here needs some refactorring I think (new 
PR?) the method now is 153 lines and takes 21 parameters. Not sure about cyclic 
complexity and I really don’t want to know anymore by now.
   
   _Originally posted by @DaanHoogland in 
https://github.com/apache/cloudstack/pull/10975#pullrequestreview-2931850389_
               


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to