DaanHoogland commented on code in PR #11220:
URL: https://github.com/apache/cloudstack/pull/11220#discussion_r2209952690
##########
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java:
##########
@@ -140,9 +140,10 @@ public void execute() throws ServerApiException {
try {
final List<LdapUser> users = _ldapManager.getUsers(domainId);
ldapResponses = createLdapUserResponse(users);
-// now filter and annotate
+ // now filter and annotate
ldapResponses = applyUserFilter(ldapResponses);
} catch (final NoLdapUserMatchingQueryException ex) {
+ logger.debug(ex.getMessage());
// ok, we'll make do with the empty list ldapResponses = new
ArrayList<LdapUserResponse>();
Review Comment:
maybe just remove the code in comment? it was already initialised on line
138.
```suggestion
// ok, we'll make do with the empty list
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
