sureshanaparti commented on code in PR #10458:
URL: https://github.com/apache/cloudstack/pull/10458#discussion_r2222937681
##########
plugins/network-elements/ovs/src/main/java/com/cloud/network/element/OvsElement.java:
##########
@@ -203,6 +204,11 @@ public boolean release(final Network network, final
NicProfile nic,
return true;
}
+ @Override
+ public boolean releaseIp(IpAddress ipAddress) {
+ return true;
Review Comment:
you can have default implementation in interface itself , not required to
override on all network elements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
