sureshanaparti commented on code in PR #10458:
URL: https://github.com/apache/cloudstack/pull/10458#discussion_r2224891690
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##########
@@ -588,15 +594,14 @@ public void doInTransactionWithoutResult(final
TransactionStatus status) {
offering =
_configMgr.createNetworkOffering(NetworkOffering.DefaultIsolatedNetworkOfferingWithSourceNatService,
"Offering for Isolated networks with Source Nat
service enabled", TrafficType.Guest, null, false, Availability.Required, null,
defaultIsolatedSourceNatEnabledNetworkOfferingProviders, true,
Network.GuestType.Isolated, false, null, true, null, false, false, null, false,
null,
- true, false, false, false, null, null,null, true,
null, null, false);
+ true, false, false, false, false, null, null,null,
true, null, null, false);
}
//#5 - default vpc offering with LB service
if
(_networkOfferingDao.findByUniqueName(NetworkOffering.DefaultIsolatedNetworkOfferingForVpcNetworks)
== null) {
offering =
_configMgr.createNetworkOffering(NetworkOffering.DefaultIsolatedNetworkOfferingForVpcNetworks,
"Offering for Isolated VPC networks with Source
Nat service enabled", TrafficType.Guest, null, false, Availability.Optional,
null,
- defaultVPCOffProviders, true,
Network.GuestType.Isolated, false, null, true, null, false, false, null, false,
null, true, true, false, false, null, null, null,true, null, null, false);
-
+ defaultVPCOffProviders, true,
Network.GuestType.Isolated, false, null, true, null, false, false, null, false,
null, true, true, false, false, false, null, null, null,true, null, null,
false);
Review Comment:
```suggestion
defaultVPCOffProviders, true,
Network.GuestType.Isolated, false, null, true, null, false, false, null, false,
null, true, true, false, false, false, null, null, null, true, null, null,
false);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
