abh1sar commented on code in PR #10140:
URL: https://github.com/apache/cloudstack/pull/10140#discussion_r2225036260


##########
api/src/main/java/com/cloud/offering/DiskOfferingInfo.java:
##########
@@ -23,6 +23,7 @@ public class DiskOfferingInfo {
     private Long _size;
     private Long _minIops;
     private Long _maxIops;
+    private Long _deviceId;

Review Comment:
   You are right. When creating instance from backup we have to replicate the 
deviceIds as stored in the backup. So I was using DiskOfferingInfo to pass all 
the information regarding the volumes to the orchestrator.
   I am using a new class VmDiskInfo now, which makes more sense.
   added in commit 
https://github.com/apache/cloudstack/pull/10140/commits/fef53cfb7520f962671ffaaf9834f512d1624c82



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to