DaanHoogland commented on code in PR #11258:
URL: https://github.com/apache/cloudstack/pull/11258#discussion_r2225112929
##########
server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java:
##########
@@ -277,7 +278,8 @@ public boolean deleteBackupOffering(final Long offeringId) {
public static String createVolumeInfoFromVolumes(List<VolumeVO> vmVolumes)
{
Review Comment:
I don’t understnd your remark @abh1sar
> can't change VolumeVO to Volume as callers are sending VolumeVO.
A `VolumeVO` is an instance of a `Volume`. Why should the method not accept
those. Should it become something like `List<? implements Volume>`?
btw, just a question….
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
