Copilot commented on code in PR #11190:
URL: https://github.com/apache/cloudstack/pull/11190#discussion_r2226264791
##########
systemvm/debian/root/monitorServices.py:
##########
@@ -263,7 +263,10 @@ def monitProcess( processes_info ):
#time for noting process down time
csec = repr(time.time()).split('.')[0]
- for process,properties in processes_info.items():
+ for process,properties in list(processes_info.items()):
+ if included_services and len(included_services) > 0 and process not in
included_services:
+ printd ("---------------------------\nskipping the service
%s\n---------------------------- " %process)
+ continue
printd ("---------------------------\nchecking the service
%s\n---------------------------- " %process)
Review Comment:
[nitpick] The debug message formatting is inconsistent with the existing
pattern on line 270. Consider using consistent separator lengths and formatting.
```suggestion
printd("---------------------------\nSkipping the service:
%s\n---------------------------" % process)
continue
printd("---------------------------\nChecking the service:
%s\n---------------------------" % process)
```
##########
core/src/main/java/com/cloud/agent/resource/virtualnetwork/model/MonitorService.java:
##########
@@ -27,6 +27,7 @@ public class MonitorService extends ConfigBase {
public Integer healthChecksBasicRunInterval;
public Integer healthChecksAdvancedRunInterval;
public String excludedHealthChecks;
Review Comment:
The new includedServices field lacks documentation. Consider adding a
JavaDoc comment to explain its purpose and expected format.
```suggestion
public String excludedHealthChecks;
/**
* A comma-separated list of services to be included for monitoring.
* This field specifies the services that should be actively monitored.
* Example: "service1,service2,service3"
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
