shwstppr commented on code in PR #11315:
URL: https://github.com/apache/cloudstack/pull/11315#discussion_r2239068461
##########
ui/src/views/infra/AddSecondaryStorage.vue:
##########
@@ -295,8 +295,10 @@ export default {
const swiftParams = {
account: values.account,
username: values.username,
- key: values.key,
- storagepolicy: values.storagepolicy
+ key: values.key
+ }
+ if (values.storagepolicy) {
Review Comment:
@DaanHoogland I don't think so. We used the pattern in many places in the
code. Also, using the suggestion would allow empty strings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
