sureshanaparti commented on code in PR #11384:
URL: https://github.com/apache/cloudstack/pull/11384#discussion_r2251141229
##########
server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java:
##########
@@ -1284,17 +1284,6 @@ public boolean restoreBackupToVM(final Long backupId,
final Long vmId) throws Re
throw new CloudRuntimeException("Unable to create Instance from
backup as the backup has a different number of disks than the Instance");
}
- int index = 0;
- for (VolumeVO vmVolume: vmVolumes) {
- Backup.VolumeInfo backupVolume = backupVolumes.get(index);
- if (vmVolume.getSize() < backupVolume.getSize()) {
- throw new CloudRuntimeException(String.format(
- "Instance volume size %d[GiB] for volume (%s) is less than
the backed-up volume size %d[GiB] for backed-up volume (%s).",
- vmVolume.getSize(), vmVolume.getUuid(),
backupVolume.getSize(), backupVolume.getUuid()));
- }
- index++;
- }
Review Comment:
@abh1sar new volumes restored will have backed-up volumes size, correct?
should we update any disk offering for the new size?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
