Pearl1594 commented on code in PR #11415:
URL: https://github.com/apache/cloudstack/pull/11415#discussion_r2294051665
##########
server/src/main/java/com/cloud/consoleproxy/AgentHookBase.java:
##########
@@ -213,10 +212,14 @@ public void startAgentHttpHandlerInVM(StartupProxyCommand
startupCmd) {
byte[] ksBits = null;
- String consoleProxyUrlDomain =
_configDao.getValue(Config.ConsoleProxyUrlDomain.key());
- String consoleProxySslEnabled =
_configDao.getValue(ConsoleProxyManager.ConsoleProxySslEnabled.key());
- if (!StringUtils.isEmpty(consoleProxyUrlDomain) &&
!StringUtils.isEmpty(consoleProxySslEnabled)
- && consoleProxySslEnabled.equalsIgnoreCase("true")) {
+ HostVO consoleProxyHost = findConsoleProxyHost(startupCmd);
+
+ assert (consoleProxyHost != null);
Review Comment:
I just used the historic code - but I'll change the approach.. to add a
meaningful error / warning ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
