rajujith commented on code in PR #7857:
URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2303236531
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateDiskOfferingCmd.java:
##########
@@ -52,106 +52,106 @@ public class CreateDiskOfferingCmd extends BaseCmd {
//////////////// API parameters /////////////////////
/////////////////////////////////////////////////////
- @Parameter(name = ApiConstants.DISK_SIZE, type = CommandType.LONG,
required = false, description = "size of the disk offering in GB (1GB =
1,073,741,824 bytes)")
+ @Parameter(name = ApiConstants.DISK_SIZE, type = CommandType.LONG,
required = false, description = "Size of the disk offering in GB (1GB =
1,073,741,824 bytes)")
private Long diskSize;
@Parameter(name = ApiConstants.DISPLAY_TEXT, type = CommandType.STRING,
description = "An alternate display text of the disk offering, defaults to
'name'.", length = 4096)
private String displayText;
- @Parameter(name = ApiConstants.NAME, type = CommandType.STRING, required =
true, description = "name of the disk offering")
+ @Parameter(name = ApiConstants.NAME, type = CommandType.STRING, required =
true, description = "Name of the disk offering")
private String offeringName;
- @Parameter(name = ApiConstants.TAGS, type = CommandType.STRING,
description = "tags for the disk offering", length = 4096)
+ @Parameter(name = ApiConstants.TAGS, type = CommandType.STRING,
description = "Tags for the disk offering", length = 4096)
private String tags;
- @Parameter(name = ApiConstants.CUSTOMIZED, type = CommandType.BOOLEAN,
description = "whether disk offering size is custom or not")
+ @Parameter(name = ApiConstants.CUSTOMIZED, type = CommandType.BOOLEAN,
description = "Whether disk offering size is custom or not")
private Boolean customized;
@Parameter(name = ApiConstants.DOMAIN_ID,
type = CommandType.LIST,
collectionType = CommandType.UUID,
entityType = DomainResponse.class,
- description = "the ID of the containing domain(s), null for public
offerings")
+ description = "The ID of the containing domain(s), null for public
offerings")
private List<Long> domainIds;
@Parameter(name = ApiConstants.ZONE_ID,
type = CommandType.LIST,
collectionType = CommandType.UUID,
entityType = ZoneResponse.class,
- description = "the ID of the containing zone(s), null for public
offerings",
+ description = "The ID of the containing zone(s), null for public
offerings",
since = "4.13")
private List<Long> zoneIds;
- @Parameter(name = ApiConstants.STORAGE_TYPE, type = CommandType.STRING,
description = "the storage type of the disk offering. Values are local and
shared.")
+ @Parameter(name = ApiConstants.STORAGE_TYPE, type = CommandType.STRING,
description = "The storage type of the disk offering. Values are local and
shared.")
private String storageType = ServiceOffering.StorageType.shared.toString();
@Parameter(name = ApiConstants.PROVISIONINGTYPE,
type = CommandType.STRING,
- description = "provisioning type used to create volumes. Valid
values are thin, sparse, fat.")
+ description = "Provisioning type used to create volumes. Valid
values are thin, sparse, fat.")
private String provisioningType = ProvisioningType.THIN.toString();
@Parameter(name = ApiConstants.DISPLAY_OFFERING,
type = CommandType.BOOLEAN,
- description = "an optional field, whether to display the offering
to the end user or not.")
+ description = "An optional field, whether to display the offering
to the end user or not.")
private Boolean displayOffering;
- @Parameter(name = ApiConstants.BYTES_READ_RATE, type = CommandType.LONG,
required = false, description = "bytes read rate of the disk offering")
+ @Parameter(name = ApiConstants.BYTES_READ_RATE, type = CommandType.LONG,
required = false, description = "Bytes read rate of the disk offering")
private Long bytesReadRate;
- @Parameter(name = ApiConstants.BYTES_READ_RATE_MAX, type =
CommandType.LONG, required = false, description = "burst bytes read rate of the
disk offering")
+ @Parameter(name = ApiConstants.BYTES_READ_RATE_MAX, type =
CommandType.LONG, required = false, description = "Burst bytes read rate of the
disk offering")
private Long bytesReadRateMax;
- @Parameter(name = ApiConstants.BYTES_READ_RATE_MAX_LENGTH, type =
CommandType.LONG, required = false, description = "length (in seconds) of the
burst")
+ @Parameter(name = ApiConstants.BYTES_READ_RATE_MAX_LENGTH, type =
CommandType.LONG, required = false, description = "Length (in seconds) of the
burst")
private Long bytesReadRateMaxLength;
- @Parameter(name = ApiConstants.BYTES_WRITE_RATE, type = CommandType.LONG,
required = false, description = "bytes write rate of the disk offering")
+ @Parameter(name = ApiConstants.BYTES_WRITE_RATE, type = CommandType.LONG,
required = false, description = "Bytes write rate of the disk offering")
private Long bytesWriteRate;
- @Parameter(name = ApiConstants.BYTES_WRITE_RATE_MAX, type =
CommandType.LONG, required = false, description = "burst bytes write rate of
the disk offering")
+ @Parameter(name = ApiConstants.BYTES_WRITE_RATE_MAX, type =
CommandType.LONG, required = false, description = "Burst bytes write rate of
the disk offering")
private Long bytesWriteRateMax;
- @Parameter(name = ApiConstants.BYTES_WRITE_RATE_MAX_LENGTH, type =
CommandType.LONG, required = false, description = "length (in seconds) of the
burst")
+ @Parameter(name = ApiConstants.BYTES_WRITE_RATE_MAX_LENGTH, type =
CommandType.LONG, required = false, description = "Length (in seconds) of the
burst")
private Long bytesWriteRateMaxLength;
- @Parameter(name = ApiConstants.IOPS_READ_RATE, type = CommandType.LONG,
required = false, description = "io requests read rate of the disk offering")
+ @Parameter(name = ApiConstants.IOPS_READ_RATE, type = CommandType.LONG,
required = false, description = "I/O requests read rate of the disk offering")
private Long iopsReadRate;
- @Parameter(name = ApiConstants.IOPS_READ_RATE_MAX, type =
CommandType.LONG, required = false, description = "burst requests read rate of
the disk offering")
+ @Parameter(name = ApiConstants.IOPS_READ_RATE_MAX, type =
CommandType.LONG, required = false, description = "Burst requests read rate of
the disk offering")
private Long iopsReadRateMax;
- @Parameter(name = ApiConstants.IOPS_READ_RATE_MAX_LENGTH, type =
CommandType.LONG, required = false, description = "length (in seconds) of the
burst")
+ @Parameter(name = ApiConstants.IOPS_READ_RATE_MAX_LENGTH, type =
CommandType.LONG, required = false, description = "Length (in seconds) of the
burst")
private Long iopsReadRateMaxLength;
- @Parameter(name = ApiConstants.IOPS_WRITE_RATE, type = CommandType.LONG,
required = false, description = "io requests write rate of the disk offering")
+ @Parameter(name = ApiConstants.IOPS_WRITE_RATE, type = CommandType.LONG,
required = false, description = "I/O requests write rate of the disk offering")
private Long iopsWriteRate;
- @Parameter(name = ApiConstants.IOPS_WRITE_RATE_MAX, type =
CommandType.LONG, required = false, description = "burst io requests write rate
of the disk offering")
+ @Parameter(name = ApiConstants.IOPS_WRITE_RATE_MAX, type =
CommandType.LONG, required = false, description = "Burst io requests write rate
of the disk offering")
Review Comment:
io -> I/O?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
