Copilot commented on code in PR #11546:
URL: https://github.com/apache/cloudstack/pull/11546#discussion_r2313173135
##########
packaging/el8/cloud.spec:
##########
@@ -17,7 +17,7 @@
%define __os_install_post %{nil}
%global debug_package %{nil}
-%global __requires_exclude libc\\.so\\..*
+%global __requires_exclude libc\\.so\\..*|libc\\.so\\.6\\(GLIBC_.*\\)
Review Comment:
The regex pattern `libc\\.so\\.6\\(GLIBC_.*\\)` may be too broad and could
exclude legitimate GLIBC dependencies that should be tracked. Consider being
more specific about which GLIBC versions to exclude to avoid masking actual
dependency issues.
```suggestion
%global __requires_exclude libc\.so\..*|libc\.so\.6\(GLIBC_2\.2\.5\)
```
##########
packaging/el8/cloud.spec:
##########
@@ -96,12 +96,12 @@ Requires: python3
Group: System Environment/Libraries
%description common
The Apache CloudStack files shared between agent and management server
-%global __requires_exclude ^(libuuid\\.so\\.1|/usr/bin/python)$
+%global __requires_exclude
libc\\.so\\..*|libc\\.so\\.6\\(GLIBC_.*\\)|^(libuuid\\.so\\.1|/usr/bin/python)$
Review Comment:
This regex combines three different exclusion patterns without proper
grouping. The `^` anchor only applies to the last part
`(libuuid\\.so\\.1|/usr/bin/python)$`, making the libc exclusions potentially
match anywhere in the dependency string. Consider restructuring as
`^(libc\\.so\\..*|libc\\.so\\.6\\(GLIBC_.*\\)|libuuid\\.so\\.1|/usr/bin/python)$`
for clarity.
```suggestion
%global __requires_exclude
^(libc\\.so\\..*|libc\\.so\\.6\\(GLIBC_.*\\)|libuuid\\.so\\.1|/usr/bin/python)$
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
