Re: [PR] update removed column for service and disk offering [cloudstack]

Mon, 01 Sep 2025 21:02:32 -0700 


sudo87 commented on PR #11544:
URL: https://github.com/apache/cloudstack/pull/11544#issuecomment-3243706574

   > @sudo87 There is no check if there any VMs or volumes in use with those 
offerings, so directly setting removed column will cause issues.
   > 
   > For example <img alt="image" width="388" height="145" 
src="https://private-user-images.githubusercontent.com/3348673/484178850-cc68155b-48b7-4c40-b2b6-f012b6cda0a3.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTY3ODU3NTMsIm5iZiI6MTc1Njc4NTQ1MywicGF0aCI6Ii8zMzQ4NjczLzQ4NDE3ODg1MC1jYzY4MTU1Yi00OGI3LTRjNDAtYjJiNi1mMDEyYjZjZGEwYTMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDkwMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTA5MDJUMDM1NzMzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MTQ1YWI3NTFkN2I3YWVjNTFmMmJlOWM3MTdkNzJmNGM0NzA5YzA5MWIwYWZmMTUxZWEzNjhiMDQwNmIwZDM2ZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.XR7SXCZSd24t6y7VeZBkEBDYo5P7FZCPl0GDDjP12cc";>
   > 
   > I think setting only state to Inactive is by design from the beginning. If 
we have to consider this fix, we need to check if there any VMs in use, also 
clearly mention in the message something like "Use updateServiceOffering with 
state Inactive" if VMs or volumes are there. I didnt think much about backward 
compatibility though
   
   Thank @harikrishna-patnala for reviewing pr. If I understand the issue 
correctly, service and disk offering remain in use by Instance/volume inspite 
of being Inactive. In that case, this fix wont suffice and design change will 
be needed.  We can close this pr. 
   
   Can we close the issue logged as bug?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to