harikrishna-patnala commented on code in PR #11410:
URL: https://github.com/apache/cloudstack/pull/11410#discussion_r2315286484
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java:
##########
@@ -297,7 +297,8 @@ public List<String> getSupportedServices() {
SourceNat.getName(),
PortForwarding.getName()));
}
- if (getNsxSupportsLbService()) {
+ if (getNsxSupportsLbService() || (provider != null &&
provider.equalsIgnoreCase("Netris") &&
Review Comment:
@Pearl1594 Please see if the methods below will help improve readability.
Otherwise LGTM
private boolean isNsxWithLb() {
return "Nsx".equalsIgnoreCase(provider) && getNsxSupportsLbService();
}
private boolean isNsxWithoutLb() {
return "Nsx".equalsIgnoreCase(provider) && !getNsxSupportsLbService();
}
private boolean isNetrisNatted() {
return "Netris".equalsIgnoreCase(provider) &&
NetworkOffering.NetworkMode.NATTED.name().equalsIgnoreCase(getNetworkMode());
}
private boolean isNetrisRouted() {
return "Netris".equalsIgnoreCase(provider) &&
NetworkOffering.NetworkMode.ROUTED.name().equalsIgnoreCase(getNetworkMode());
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
