shwstppr commented on code in PR #11558:
URL: https://github.com/apache/cloudstack/pull/11558#discussion_r2315455872
##########
server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java:
##########
@@ -1694,9 +1694,13 @@ public Snapshot allocSnapshot(Long volumeId, Long
policyId, String snapshotName,
Type snapshotType = getSnapshotType(policyId);
Account owner = _accountMgr.getAccount(volume.getAccountId());
+ ResourceType storeResourceType = ResourceType.secondary_storage;
+ if (!isBackupSnapshotToSecondaryForZone(zoneIds.get(0)) ||
Snapshot.LocationType.PRIMARY.equals(locationType)) {
+ storeResourceType = ResourceType.primary_storage;
Review Comment:
I'm not sure if we should even check for the primary store
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
