shwstppr commented on code in PR #11571:
URL: https://github.com/apache/cloudstack/pull/11571#discussion_r2321214607
##########
ui/src/views/setting/ConfigurationValue.vue:
##########
@@ -254,6 +258,17 @@ export default {
this.setConfigData()
},
watch: {
+ loading (newVal, oldVal) {
Review Comment:
Is loading value for the element set somewhere in the code?
Similarly for property `configDisable`, though unrelated to the PR
##########
ui/src/views/setting/ConfigurationValue.vue:
##########
@@ -280,6 +295,9 @@ export default {
name: configrecord.name,
value: newValue
}
+ if (this.scopeKey === 'domainid' && !params[this.scopeKey]) {
Review Comment:
do we need the this.scopeKey === 'domainid' check? Can it be
```suggestion
if (this.scopeKey && !params[this.scopeKey]) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
