sudo87 commented on PR #11541: URL: https://github.com/apache/cloudstack/pull/11541#issuecomment-3254566076
Thanks @shwstppr and @weizhouapache for quick review and feedback. toVmTO method only add cpu,memory and os related info in vmTO. We need new method: ``` prepVmSpecForUnmanageCmd(Long vmId, Long hostId) ``` To add all relevant sections for instance, as mentioned by abhishek: ``` Check and compare how it is prepared for the StartCommand and if we can re-use bits of the code Check if there would be some other params for the VM that may get missed - VM details, boot configs, extraconfig, default NICs, ROOT vs DATA volumes, etc. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
