rg9975 commented on code in PR #11071:
URL: https://github.com/apache/cloudstack/pull/11071#discussion_r2333310326
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/MultipathSCSIAdapterBase.java:
##########
@@ -164,9 +178,10 @@ private KVMPhysicalDisk getPhysicalDisk(AddressInfo
address, KVMStoragePool pool
// validate we have a connection, if not we need to connect first.
if (!isConnected(address.getPath())) {
- if (!connectPhysicalDisk(address, pool, null)) {
- throw new CloudRuntimeException("Unable to connect to volume "
+ address.getPath());
- }
+ LOGGER.debug("Physical disk " + address.getPath() + " is not
connected, a request to connectPhysicalDisk must be made before it can be
used.");
Review Comment:
This is intentional in the change. The getPhysicalDisk operation expects
that a previous call to connectPhysicalDisk has already been made. If it has
not been made, an error is thrown. This allows for asynchronous connections to
be processed by the storage provider to improve startup of virtual machines
with a large # of attached disks rather than a connection being created as side
effect of a getPhysicalDisk call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
