nvazquez commented on code in PR #11601:
URL: https://github.com/apache/cloudstack/pull/11601#discussion_r2338240648
##########
plugins/hypervisors/external/src/main/java/org/apache/cloudstack/hypervisor/external/provisioner/ExternalPathPayloadProvisioner.java:
##########
@@ -455,6 +472,52 @@ public Map<String, HostVmStateReportEntry>
getHostVmStateReport(long hostId, Str
return vmStates;
}
+ @Override
+ public GetExternalConsoleAnswer getInstanceConsole(String hostGuid, String
extensionName,
+ String extensionRelativePath,
GetExternalConsoleCommand cmd) {
+ String extensionPath = getExtensionCheckedPath(extensionName,
extensionRelativePath);
+ if (StringUtils.isEmpty(extensionPath)) {
+ return new GetExternalConsoleAnswer(cmd, "Extension not
configured");
Review Comment:
Here also the extension name? Same on the log messages and responses below?
##########
framework/extensions/src/main/java/org/apache/cloudstack/framework/extensions/manager/ExtensionsManagerImpl.java:
##########
@@ -1517,6 +1530,22 @@ public void updateExtensionResourceMapDetails(long
extensionResourceMapId, Map<S
extensionResourceMapDetailsDao.saveDetails(detailsList);
}
+ @Override
+ public Answer getInstanceConsole(VirtualMachine vm, Host host) {
+ Extension extension = getExtensionForCluster(host.getClusterId());
+ if (extension == null ||
!Extension.Type.Orchestrator.equals(extension.getType()) ||
+ !Extension.State.Enabled.equals(extension.getState())) {
+ return new Answer(null, false, "No enabled orchestrator extension
found for the host");
Review Comment:
Minor comment: can we also return the host name and/or UUID on the message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
