bernardodemarco opened a new pull request, #11616:
URL: https://github.com/apache/cloudstack/pull/11616

   ### Description
   
   The `vmsnapshot.max` global setting is used to control the maximum number of 
VM snapshots that can be taken for a single VM. However, its scope is global 
and, thus, when configured, all accounts of the ACS environment will have to 
comply with the same limitation.      
   
   This PR proposes to change the setting's scope to the account level, 
enabling for the cloud operators to define different limitations for different 
accounts.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [X] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   - [ ] test (unit or integration test code)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [X] Minor
   - [ ] Trivial
   
   ### Screenshots (if appropriate):
   
   ### How Has This Been Tested?
   
   - Defined the `vmsnapshot.max` global value as `2`
   - Checked that the limitation was correctly enforced for all accounts
   - Defined the `vmsnapshot.max` value to `1` for a user account
   - Checked that the above limitation was correctly enforced for the user 
account
   - Checked that the global limitation was still enforced for the others 
accounts 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to