DaanHoogland commented on code in PR #11531:
URL: https://github.com/apache/cloudstack/pull/11531#discussion_r2348098564
##########
server/src/main/java/com/cloud/api/ApiResponseHelper.java:
##########
@@ -4330,6 +4330,9 @@ public UsageRecordResponse createUsageResponse(Usage
usageRecord, Map<String, Se
if (volume != null) {
builder.append("for ").append(volume.getName()).append("
(").append(volume.getUuid()).append(")");
}
+ if (vmInstance != null) {
+ builder.append(" attached to VM
").append(vmInstance.getHostName()).append("
(").append(vmInstance.getUuid()).append(")");
+ }
Review Comment:
this is adding only three lines to a 530 line method. No issue in the
context but `public UsageRecordResponse createUsageResponse(Usage usageRecord)`
needs to be refactorred (as many pieces of code).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
