StepBee commented on PR #11632: URL: https://github.com/apache/cloudstack/pull/11632#issuecomment-3291154196
> > @StepBee the commands worked in our testing > > however, @Copilot suggested to use the following , which looks more easy > > ``` > > QEMU_GROUP=$(sed -n 's/^group\s*=//p' /etc/libvirt/qemu.conf | tr -d '"' | tr -d ' ' | tail -n1) > > ``` > > also, do we consider single quote in the value, for example `group = 'root'` ? > > I agree with @weizhouapache. IMO we should consider single quotes as well in the configuration. > > @StepBee the commands worked in our testing > > however, @Copilot suggested to use the following , which looks more easy > > ``` > > QEMU_GROUP=$(sed -n 's/^group\s*=//p' /etc/libvirt/qemu.conf | tr -d '"' | tr -d ' ' | tail -n1) > > ``` > > > > also, do we consider single quote in the value, for example `group = 'root'` ? > > I agree with @weizhouapache. IMO we should consider single quotes as well in the configuration. Thank you @vishesh92 @weizhouapache i agree, the awk was not required and it's good to catch single quote as during this fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
