nvazquez commented on code in PR #11594:
URL: https://github.com/apache/cloudstack/pull/11594#discussion_r2363858878


##########
server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java:
##########
@@ -2852,6 +2954,103 @@ public ListResponse<UnmanagedInstanceResponse> 
listVmsForImport(ListVmsForImport
         return listResponses;
     }
 
+    @Override
+    public ListResponse<ImportVMTaskResponse> 
listImportVMTasks(ListImportVMTasksCmd cmd) {

Review Comment:
   Thanks @shwstppr - fixed



##########
api/src/main/java/org/apache/cloudstack/api/command/admin/vm/ImportVmCmd.java:
##########
@@ -159,6 +159,16 @@ public class ImportVmCmd extends 
ImportUnmanagedInstanceCmd {
             description = "(only for importing VMs from VMware to KVM) 
optional - if true, forces MS to export OVF from VMware to temporary storage, 
else uses KVM Host if ovftool is available, falls back to MS if not.")
     private Boolean forceMsToImportVmFiles;
 
+    @Parameter(name = "extraparams",
+            type = CommandType.STRING,
+            since = "4.22",
+            description = "(VMware to KVM only) extra parameters to be passed 
on the virt-v2v command, if allowed by the administrator")
+    private String extraParams;
+
+    @Parameter(name = "forceconverttopool", type = CommandType.BOOLEAN,
+            description = "(only for importing VMs from VMware to KVM) 
optional - if true, forces virt-v2v conversions to write directly on the 
provided storage pool (avoid using temporary conversion pool).")
+    private Boolean forceConvertToPool;
+

Review Comment:
   Sure, fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to