sureshanaparti commented on code in PR #11637:
URL: https://github.com/apache/cloudstack/pull/11637#discussion_r2348717216
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java:
##########
@@ -1499,6 +1502,14 @@ protected String[] createUserApiKeyAndSecretKey(long
userId) {
}
}
+ protected String generateRandomUserPassword(Long domainId) {
+ Integer passwordPolicyMinimumLength =
PasswordPolicy.PasswordPolicyMinimumLength.valueIn(domainId);
+ if (passwordPolicyMinimumLength == null || passwordPolicyMinimumLength
< CKS_USER_MIN_PASSWORD_LENGTH) {
+ passwordPolicyMinimumLength = CKS_USER_MIN_PASSWORD_LENGTH;
Review Comment:
as you are addressing it, better not allow less than 10 as minimum length
for passwords (if not in 4.20.2, we can address in 4.22, need to add a check
for config)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
