weizhouapache commented on PR #10735:
URL: https://github.com/apache/cloudstack/pull/10735#issuecomment-3265883524

   @shwstppr 
   the issue #10163 is present in my testing
   
   it looks like we need to set the storage netmask and gateway too
   
   ```
   diff --git 
a/services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
 
b/services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
   index 454b98d0f6e..4eb45f2b5b9 100644
   --- 
a/services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
   +++ 
b/services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
   @@ -2744,8 +2744,8 @@ public class NfsSecondaryStorageResource extends 
ServerResourceBase implements S
            if (_storageIp == null && _inSystemVM) {
                logger.warn("There is no storageip in /proc/cmdline, something 
wrong!");
            }
   -        _storageNetmask = (String)params.get("storagenetmask");
   -        _storageGateway = (String)params.get("storagegateway");
   +        _storageNetmask = MapUtils.getString(params, "storagenetmask", 
_eth1mask);
   +        _storageGateway = MapUtils.getString(params, "storagegateway", 
(String)params.get("localgw"));
            super.configure(name, params);
    
            _params = params;
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to