sureshanaparti commented on PR #11666: URL: https://github.com/apache/cloudstack/pull/11666#issuecomment-3322728414
> > > @sureshanaparti this LGTM. one request out of the scope of this issue. I see this setting is of cluster scope and there is a usage of this without clusterId, can you please add that here too. > > > https://github.com/shapeblue/cloudstack/blob/9fee6dae34cc233ee6644ed6fe5499d3103f9f3a/server/src/main/java/com/cloud/storage/listener/StoragePoolMonitor.java#L150 > > > > > > did you mean `zoneId` ? @harikrishna-patnala 👍 > > no @weizhouapache clusterId only, as the scope is of cluster @harikrishna-patnala @weizhouapache for zone-wide pools, we cannot consider clustered scope value (as each cluster in the zone can have different setting), so I think, that's the reason it's picked from global scope there. in case, to change to multi-scope config, we can address later in a separate pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
