weizhouapache commented on code in PR #11654:
URL: https://github.com/apache/cloudstack/pull/11654#discussion_r2371621996


##########
engine/userdata/src/main/java/org/apache/cloudstack/userdata/UserDataManagerImpl.java:
##########
@@ -137,7 +139,11 @@ public String validateAndGetUserDataForSystemVM(String 
userDataUuid) {
             return null;
         }
         if (userDataVo.getDomainId() == Domain.ROOT_DOMAIN && 
userDataVo.getAccountId() == User.UID_ADMIN) {
-            return userDataVo.getUserData();
+            // Decode base64 user data, compress it, then re-encode to reduce 
command line length

Review Comment:
   @vishesh92 
   can you maybe test some userdata and share the length of base64-encoded 
userdata and base64-encoded compressed userdata ? just curious about the 
compression rate



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to