weizhouapache commented on code in PR #11696:
URL: https://github.com/apache/cloudstack/pull/11696#discussion_r2371289010
##########
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/OpenLdapUserManagerImpl.java:
##########
@@ -87,7 +87,7 @@ private String generateSearchFilter(final String username,
Long domainId) {
usernameFilter.append((username == null ? "*" :
LdapUtils.escapeLDAPSearchFilter(username)));
usernameFilter.append(")");
- String memberOfAttribute =
_ldapConfiguration.getUserMemberOfAttribute(domainId);
+ String memberOfAttribute = getMemberOfAttribute(domainId);
Review Comment:
@DaanHoogland
there is a method in the same file
```
protected String getMemberOfAttribute(final Long domainId) {
return _ldapConfiguration.getUserMemberOfAttribute(domainId);
}
```
which is used only once
```
if ("GROUP".equals(type)) {
memberOfFilter.append("(").append(getMemberOfAttribute(domainId)).append("=");
memberOfFilter.append(name);
memberOfFilter.append(")");
}
```
is it correct ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
