abh1sar commented on code in PR #11684:
URL: https://github.com/apache/cloudstack/pull/11684#discussion_r2381336979
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtTakeBackupCommandWrapper.java:
##########
@@ -44,7 +49,22 @@ public Answer execute(TakeBackupCommand command,
LibvirtComputingResource libvir
final String backupRepoType = command.getBackupRepoType();
final String backupRepoAddress = command.getBackupRepoAddress();
final String mountOptions = command.getMountOptions();
- final List<String> diskPaths = command.getVolumePaths();
+ List<PrimaryDataStoreTO> volumePools = command.getVolumePools();
+ final List<String> volumePaths = command.getVolumePaths();
+ KVMStoragePoolManager storagePoolMgr =
libvirtComputingResource.getStoragePoolMgr();
+
+ List<String> diskPaths = new ArrayList<>();
+ for (int idx = 0; idx < volumePaths.size(); idx++) {
+ PrimaryDataStoreTO volumePool = volumePools.get(idx);
Review Comment:
nit: we can put this in the else block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
