weizhouapache commented on code in PR #11318:
URL: https://github.com/apache/cloudstack/pull/11318#discussion_r2432799735
##########
python/lib/cloudutils/networkConfig.py:
##########
@@ -150,10 +153,10 @@ def getDevInfo(dev):
if line.find("HWaddr") != -1:
Review Comment:
It seems `cmd.getLines()` has never been worked .....
a change might be needed
```
diff --git a/python/lib/cloudutils/utilities.py
b/python/lib/cloudutils/utilities.py
index 5f7e34ed61d..31f35ee6d44 100755
--- a/python/lib/cloudutils/utilities.py
+++ b/python/lib/cloudutils/utilities.py
@@ -63,7 +63,7 @@ class bash:
return self.stdout.decode('utf-8').strip('\n')
def getLines(self):
- return self.stdout.decode('utf-8').strip('\n')
+ return self.stdout.decode('utf-8').strip('\n').split('\n')
def getStderr(self):
return self.stderr.decode('utf-8').strip('\n')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
