abh1sar commented on code in PR #11754:
URL: https://github.com/apache/cloudstack/pull/11754#discussion_r2419715174
##########
server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java:
##########
@@ -2102,6 +2113,12 @@ Map<String, String> getDetailsFromBackupDetails(Long
backupId) {
details.put(ApiConstants.IS_ISO,
String.valueOf(template.getFormat().equals(Storage.ImageFormat.ISO)));
}
}
+ if (details.containsKey(ApiConstants.OS_TYPE_ID)) {
+ GuestOSVO guestOS =
_guestOSDao.findByUuid(details.get(ApiConstants.OS_TYPE_ID));
+ if (guestOS != null) {
+ details.put(ApiConstants.OS_NAME, guestOS.getDisplayName());
+ }
Review Comment:
I followed the same pattern as Template and ServiceOffering as I didn't want
to store too many derived properties in the details table. But I guess it is ok
for guestOS as it does simplify the code a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
