Re: [PR] ui: Allow edit source CIDR on load balancer rule [cloudstack]

Sat, 18 Oct 2025 04:07:52 -0700 


CodeBleu commented on PR #11766:
URL: https://github.com/apache/cloudstack/pull/11766#issuecomment-3385930096

   > @DaanHoogland , @CodeBleu - I’ve completed testing this on my test 
environment.
   > 
   > 1. Creating a Load Balancer rule with single/multiple CIDRs (e.g. 
1.1.1.1/32,2.2.2.0/24,3.3.3.3/32) **works as expected.**
   > 2. **Editing** an existing rule and **appending** additional CIDRs 
**fails** with:
   > 
   > _Failed to edit rule Invalid CIDR list: 1.1.1.1/32 2.2.2.0/24,3.3.3.3/32_
   > 
   > <img alt="image" width="2000" height="1623" 
src="https://private-user-images.githubusercontent.com/201906357/499325516-80728ac8-8b6b-4d98-99ac-ede56aafbbac.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjAwMTY0NzUsIm5iZiI6MTc2MDAxNjE3NSwicGF0aCI6Ii8yMDE5MDYzNTcvNDk5MzI1NTE2LTgwNzI4YWM4LThiNmItNGQ5OC05OWFjLWVkZTU2YWFmYmJhYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUxMDA5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MTAwOVQxMzIyNTVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05ZmFmZWIzMjQxMzMzNTNhNDJhMzYyYmVjZmYzZjlhOTI4MzExMjBhZjk4NTBmMDc3MmNlNWUxZWZhNzVmMWM0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.ibstzrbQibjFGmV7xfizP27-_S8wkYMsuhGo_R9mSFY";>
   > The input was entered correctly (no spaces), but during the edit flow the 
UI alters the CIDR string - a space replaces the first comma between the CIDRs, 
resulting in a malformed value being sent to the backend.
   > 
   > Browser console shows:
   > 
   > _Uncaught (in promise) TypeError: Cannot read properties of undefined 
(reading 'push') at LoadBalancing.vue:1188_
   > 
   > ➝ This confirms the issue is UI-related, not API-related.
   > 
   > <img alt="image" width="2000" height="294" 
src="https://private-user-images.githubusercontent.com/201906357/499326015-7e304403-fb2b-4266-b422-343c925f0c23.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjAwMTY0NzUsIm5iZiI6MTc2MDAxNjE3NSwicGF0aCI6Ii8yMDE5MDYzNTcvNDk5MzI2MDE1LTdlMzA0NDAzLWZiMmItNDI2Ni1iNDIyLTM0M2M5MjVmMGMyMy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUxMDA5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MTAwOVQxMzIyNTVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iNWIzNzgxNmYzZGU4YTliNTYwNWE1NmJhNTA3Y2RjYTEwYjY5MGM3MDc1ZjI1MTlmNzlkNDE0ZGRmNTRjZWNhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.JVYPIbPSFDnJNZ6z9fr7CNDLnKsn_4Ol8Oj-7_wy8A0";>
   > Backend log showing malformed CIDR string (space between 1st and 2nd CIDR) 
received during UpdateLoadBalancerRuleCmd.
   > 
   >  Screencast.from.2025-10-09.15-02-15.webm 
   >  Screencast.from.2025-10-09.15-19-14.webm 
   > **Summary**:
   > 
   > * Multiple CIDRs work on rule creation.
   > * Single CIDRs work on rule creation.
   > * Multiple CIDRs break when editing due to the UI transforming the CIDR 
list incorrectly.
   > * API itself accepts the correct format.
   > 
   > Happy to retest after a fix.
   
   @rosi-shapeblue 
   
   Your first video has spaces in the list of IP's, even though you added the 
new one with a ','.
   <img width="771" height="675" alt="image" 
src="https://github.com/user-attachments/assets/0a9a8489-d874-4529-965b-c642034830ec";
 />
   
   The second video I'm not sure what happened there, and am unable to 
reproduce on my end. I'm able to add and update multiple times with using ',' 
between CIDRs.  The only thing I see in that video is the name of the rule is 
the same as the one that is bad and has spaces in the list.
   
   Do you mind testing again and making sure there are no spaces?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to